fix(v4-sdk): correct domain.name casing in getPermitData #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
fix(v4): correct domain.name casing in getPermitData
Description
This PR corrects the casing of the
domain.namefield returned byV4PositionManager.getPermitDatafrom "Uniswap V4 Positions NFT" to "Uniswap v4 Positions NFT", aligning it with the actual contract deployment and EIP-712 signature verification expectations.This change ensures consistent behavior with frontend and signature validation tools that depend on exact string casing.
How Has This Been Tested?
getPermitDataoutputAre there any breaking changes?
No breaking changes.